Skip to content

[TASK] Drop redundant OutputException constructor #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2025
Merged

[TASK] Drop redundant OutputException constructor #925

merged 1 commit into from
Feb 16, 2025

Conversation

oliverklee
Copy link
Collaborator

No description provided.

@oliverklee oliverklee requested a review from JakeQZ February 14, 2025 22:19
@oliverklee oliverklee self-assigned this Feb 14, 2025
@coveralls
Copy link

coveralls commented Feb 14, 2025 •
edited
Loading

Coverage Status

coverage: 50.42% (-0.08%) from 50.498%
when pulling 2ed8ad3 on cleanup/redundant-exceptions
into e1fa3b6 on main.

JakeQZ
JakeQZ reviewed Feb 15, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with PHP and undefined constructors, which is why I always provide an empty constructor in the base class. I can't recall the details. I don't think that's a problem here, but will need to check.

@oliverklee oliverklee force-pushed the cleanup/redundant-exceptions branch from 3dcc81a to 70fbfd1 Compare February 15, 2025 09:42
@oliverklee
Copy link
Collaborator Author

In this case, the direct parent class SourceException has a constructor.

@oliverklee oliverklee force-pushed the cleanup/redundant-exceptions branch from 70fbfd1 to 2ed8ad3 Compare February 15, 2025 12:20
JakeQZ
JakeQZ approved these changes Feb 16, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine: SourceException has a constructor. This might have already been covered by #932...

@JakeQZ JakeQZ merged commit 6775b97 into main Feb 16, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/redundant-exceptions branch February 16, 2025 02:11
@JakeQZ
Copy link
Collaborator

JakeQZ commented Feb 16, 2025

This might have already been covered by #932...

That was for a different class (PrimitiveValue), but a likewise change.

In this case, the direct parent class SourceException has a constructor.

I missed that comment before commenting on having reached the same conclusion :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ